fix(tests): restore whitelisted smoke job in quantum integration test#471
Merged
Conversation
run_autorun_job rejects non-whitelisted job names before status lookup; restore smoke as the test job name so list/dict status parsing is exercised. Co-authored-by: Bryan <bryan@users.noreply.github.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjust quantum integration test to use the whitelisted 'smoke' autorun job so the test exercises status parsing instead of failing job-name validation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
🟡 Coverage —
|
| Metric | Value |
|---|---|
| Total coverage | 65.3% |
▲ vs main |
+0.1% |
| Minimum threshold | 60% |
Updated on every push · 2026-06-20
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The test now hardcodes the whitelisted
"smoke"job name in multiple places; consider deriving the allowed job name(s) from the same source used byrun_autorun_job(or a shared constant/fixture) so that whitelist changes don’t silently desync from this test.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The test now hardcodes the whitelisted `"smoke"` job name in multiple places; consider deriving the allowed job name(s) from the same source used by `run_autorun_job` (or a shared constant/fixture) so that whitelist changes don’t silently desync from this test.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🔐 CodeQL — Open Alerts on this PR
Copilot Autofix suggestions (if enabled) appear as inline review comments on the affected lines. |
Author
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_ff725e8e-cf21-4c5c-999c-d89fe97a873d) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hourly repo health automation failed on
pre_commit_checkbecausetests/test_quantum_integration.pyused a non-whitelisted autorun job name (another).run_autorun_jobvalidates job names before reading status, so the test never reached the list/dict status parsing logic it was meant to exercise.Changes
test_run_autorun_job_reads_status_for_list_and_dict_shapesto use the whitelistedsmokejob name in parametrized payloads and assertions.Verification
pytest tests/test_quantum_integration.py— 2 passedCo-authored-by: Bryan bryan@users.noreply.github.com
Summary by Sourcery
Tests:
Note
Low Risk
Test-only fixture and assertion renames; no production or integration behavior changes.
Overview
Renames the autorun job used in
test_run_autorun_job_reads_status_for_list_and_dict_shapesfromanothertosmokein parametrized status payloads, therun_autorun_jobcall, and assertions.This aligns the test with
run_autorun_job’s allowed job whitelist so the case reaches list/dict status parsing instead of failing early on invalid job names (which brokepre_commit_checkin repo health automation).Reviewed by Cursor Bugbot for commit 633b851. Bugbot is set up for automated code reviews on this repo. Configure here.